[aggregator] Pool locked aggregations #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
approved these changes
May 2, 2022
| sourcesSeen map[uint32]*bitset.BitSet, | ||
| ) *lockedCounterAggregation { | ||
| l := lockedCounterAggregationPool.Get().(*lockedCounterAggregation) | ||
| l.aggregation = aggregation |
There was a problem hiding this comment.
Nit: could factor the zeroing into a reset method, and reuse here + in close? Not a huge deal though.
There was a problem hiding this comment.
I simplified and made close() foolproof
andrewmains12
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is about ~30% allocs by space on timed metric heavy workloads:
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: